Updates:
        Summary: ExtensionDownloader::FetchUpdatedExtension crashes browser on  
every launch
        Status: Assigned

Comment #8 on issue 130881 by a...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

(No comment was entered for this change.)

Updates:
        Cc: m...@chromium.org pawli...@chromium.org

Comment #9 on issue 130881 by k...@google.com:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

(No comment was entered for this change.)

Updates:
        Labels: -Pri-1 -Type-Bug Pri-0 Type-Regression ReleaseBlock-Dev

Comment #10 on issue 130881 by k...@google.com:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

(No comment was entered for this change.)

Updates:
        Cc: mih...@chromium.org

Comment #11 on issue 130881 by mih...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Antony is out on vacation (though getting back tomorrow). How sure are we  
that his ExtensionDownloader changes are responsible? The last change to  
that landed r139371, which first appeared in 21.0.1156.0 (a few canary  
builds before the first report in his bug).

If it is a problem with Antony's changes, note that they got merged into  
the M20 branch too (see last few commits on bug 129587)

I would bisect except I can't reproduce locally.

Comment #12 on issue 130881 by ijpedow...@google.com:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

This had happened for a few Canary builds, but I held off on reporting  
until I could find the proper repro (not installing my extensions).  Feel  
free to inspect my account data to see which extensions I am using.

Comment #13 on issue 130881 by a...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I'm not 100% sure. But he touched the code that is the last to run before  
the crash, and he did it about a week ago, which is about right since the  
dev channel just updated to a build that did this for me too.

Comment #15 on issue 130881 by asarg...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I'm not yet able to reproduce this locally. Would anyone who is able to be  
willing to share a copy of their profile directory with me? (Please do not  
attach it to this bug, instead contact me directly).

Alternatively, could someone with such a profile build a version of chrome  
with the following two changes locally reverted:

svn revision 139371 (git 07c8689428a554ad42629de523673cde5e37d56b)
svn revision 138961 (git 37233482332d14311069f79b25b113c9886cb2c8)

and run that pointed at the profile and see if you get the same crash?

Comment #16 on issue 130881 by rse...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131318 has been merged into this issue.

Comment #17 on issue 130881 by bugdro...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881#c17

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=140869

------------------------------------------------------------------------
r140869 | asarg...@chromium.org | Wed Jun 06 15:37:59 PDT 2012

Changed paths:
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensi...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extens...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensi...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extens...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extens...

Revert r139371 and r138961

These seem to be causing crashes at startup for some users.

TBR=asarg...@chromium.org

BUG=130881
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10532037
------------------------------------------------------------------------

Comment #18 on issue 130881 by asarg...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I think this must have something to do with sync state, because I still  
could not reproduce the problem when running against a copy of Avi's  
profile that he sent me (I was lacking his sync credentials that are stored  
in the OSX keychain).

For now I've reverted the CL's on trunk while I continue to investigate,  
and would appreciate it if someone could let me know if the next canary  
build to come out makes the crashes go away.

Updates:
        Cc: willc...@chromium.org asarg...@chromium.org

Comment #19 on issue 130881 by mih...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131538 has been merged into this issue.

Comment #20 on issue 130881 by qui...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Seeing the same problem on ChromeOS. (Chrome version 21.0.1166.0 Official  
Build 140819, ChromeOS version 2404.0.0).

The revision number looks older than your CL, so I'll wait for a newer  
version. But let me know if you want to get my profile data.

Comment #21 on issue 130881 by kar...@google.com:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

today's Mac canary had this change as far as Ican see. Avi,do you still see  
this problem on the Mac?

Comment #22 on issue 130881 by a...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Alas, yes.

Process:         Google Chrome Canary [43293]
Path:            /Applications/Google Chrome  
Canary.app/Contents/MacOS/Google Chrome Canary
Identifier:      com.google.Chrome.canary
Version:         21.0.1167.0 (1167.0)
Code Type:       X86 (Native)
Parent Process:  launchd [302]

http://crash.corp.google.com/reportdetail?reportid=5a2a434dc6d5dc0f

I had difficulty bisecting this morning because each new version of  
Chromium forced me to reauthorize my keychain items, yielding hundreds of  
alerts. I'm going to try again with official builds and see if that helps.

Comment #23 on issue 130881 by anna...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131807 has been merged into this issue.

Comment #24 on issue 130881 by kar...@google.com:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

ok so we're planning on doing a dev release on Monday, is there something  
we can do so we can make this build releasable in case u can't find the  
issue? does everyone crash?

Comment #25 on issue 130881 by a...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

This is already broken on dev. Pushing another dev with it broken sucks but  
doesn't make things any worse.

Updates:
        Cc: a...@chromium.org

Comment #26 on issue 130881 by kar...@google.com:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

adding aaron.

Updates:
        Labels: Feature-Sync

Comment #27 on issue 130881 by anna...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

+sync team.

Comment #28 on issue 130881 by a...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

There were a few changes a few days earlier by akalin that look like they  
could maybe be related?

https://chromiumcodereview.appspot.com/10392192 (may 22)
https://chromiumcodereview.appspot.com/10412050 (may 23)

Updates:
        Cc: aka...@chromium.org

Comment #29 on issue 130881 by kar...@google.com:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

fred, is it possible? if so, can we maybe revert them for a day and see if  
they are somehow causing the issue?

Comment #30 on issue 130881 by t...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Bug 131807 mentions this worked if --disable-sync is passed. My hunch there  
is that sync sent an extension over to a machine, and it is sitting in sync  
state waiting to be "installed", and the first step is to fetch the URL.  
The crash occurs when trying to fetch, but that fetch would not have  
happened if sync wasn't in the picture (so I think sync is a slight red  
herring, but not ruling it out).

I'm taking a look at akalin's patches now. He's ooo this week.

Comment #31 on issue 130881 by anna...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

avi@, as you are still seeing, could you please try passing the following  
flags:
--disable-extensions-file-access-check
--disable-extensions-resource-whitelist
--disable-extensions-http-throttling

Also, I assume you are syncing - is any of the accounts 2-factor enabled?

Comment #32 on issue 130881 by a...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

On my personal MacBook I have two accounts: corp Google and home (an AFYD  
dasher). Both have 2-factor.

OTOH, I have the same two accounts set up with work Chrome and don't see an  
issue.

Will try the flags and post results.

Comment #33 on issue 130881 by a...@chromium.org:  
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

--disable-extensions-file-access-check
--disable-extensions-resource-whitelist
--disable-extensions-http-throttling

None of those flags changed the behavior; it still crashed.