Re: Issue 114549 in chromium: Enable --force-compositing-mode on desktop platforms

13 views
Skip to first unread message

chro...@googlecode.com

unread,
Feb 16, 2012, 1:46:55 AM2/16/12
to chromi...@chromium.org
Updates:
Blockedon: 114551

Comment #4 on issue 114549 by nd...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

(No comment was entered for this change.)

chro...@googlecode.com

unread,
May 7, 2012, 7:13:40 PM5/7/12
to chromi...@chromium.org
Updates:
Blockedon: -100666

Comment #8 on issue 114549 by en...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

I realize that I was the one who added this, but I don't think bug 100666
(skia AA text) is really a blocker for this. Force compositing mode won't
create additional layers--it will just make the root layer composited in
cases where it wasn't before, and the root layer always has AA text.

chro...@googlecode.com

unread,
May 16, 2012, 3:22:28 PM5/16/12
to chromi...@chromium.org

Comment #9 on issue 114549 by vange...@google.com: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

I will enable it at ToT to start collecting data from the Canary. There is
investigation underway to understand performance painpoints and hopefully
deal with them before M21 ships.


chro...@googlecode.com

unread,
May 16, 2012, 10:29:07 PM5/16/12
to chromi...@chromium.org

Comment #11 on issue 114549 by vange...@google.com: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

I don't think it's going to be that bad! But there's only one way to find
out.

chro...@googlecode.com

unread,
May 17, 2012, 1:36:02 AM5/17/12
to chromi...@chromium.org
Updates:
Blockedon: chromium:128058

Comment #12 on issue 114549 by vange...@google.com: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

I'd like to get the tab changing flash (issue 128058) resolved before we
can turn this on in canary.

chro...@googlecode.com

unread,
May 17, 2012, 2:13:29 AM5/17/12
to chromi...@chromium.org

Comment #13 on issue 114549 by nd...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

Yep, working on that again tomorrow

chro...@googlecode.com

unread,
May 23, 2012, 10:49:38 PM5/23/12
to chromi...@chromium.org
Updates:
Owner: vang...@chromium.org
Cc: nd...@chromium.org
Blockedon: chromium:129194

Comment #14 on issue 114549 by vange...@google.com: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

chro...@googlecode.com

unread,
May 23, 2012, 10:52:38 PM5/23/12
to chromi...@chromium.org
Updates:
Blockedon: chromium:123103

Comment #15 on issue 114549 by vange...@google.com: Enable

chro...@googlecode.com

unread,
May 23, 2012, 10:53:38 PM5/23/12
to chromi...@chromium.org
Updates:
Labels: Mstone-21

Comment #16 on issue 114549 by vange...@google.com: Enable

chro...@googlecode.com

unread,
Jun 7, 2012, 9:50:40 PM6/7/12
to chromi...@chromium.org
Updates:
Blockedon: -chromium:114410

Comment #17 on issue 114549 by vange...@google.com: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

I don't think per-tile-painting should be blocking this bug. So far it's
been somewhat of a mixed bag in terms of perf benefits.

Canary experiment took longer than I thought but it's finally ready for
landing:
https://chromiumcodereview.appspot.com/10541019/



chro...@googlecode.com

unread,
Jun 7, 2012, 11:12:41 PM6/7/12
to chromi...@chromium.org

Comment #18 on issue 114549 by bugdro...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549#c18

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=141164

------------------------------------------------------------------------
r141164 | vang...@chromium.org | Thu Jun 07 20:09:09 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=141164&r2=141163&pathrev=141164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gpu_util.cc?r1=141164&r2=141163&pathrev=141164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gpu_util.h?r1=141164&r2=141163&pathrev=141164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=141164&r2=141163&pathrev=141164

Adding a field trial for testing --force-compositing-mode on 50% of
canary users.
BUG=114549

Review URL: https://chromiumcodereview.appspot.com/10541019
------------------------------------------------------------------------

chro...@googlecode.com

unread,
Jun 8, 2012, 3:33:22 PM6/8/12
to chromi...@chromium.org

Comment #19 on issue 114549 by vang...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

50% Canary experiment is live as of today (Win and Mac). It's tied to your
client id so you either get it or not... You can tell whether you're in it
if:

1. about:version doesn't show the --force-compositing-mode flag, AND
2. about:gpu reports "Compositing: Hardware accelerated on all pages"


chro...@googlecode.com

unread,
Jun 13, 2012, 2:27:12 AM6/13/12
to chromi...@chromium.org

Comment #21 on issue 114549 by bugdro...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549#c21

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=141862

------------------------------------------------------------------------
r141862 | vang...@chromium.org | Tue Jun 12 23:23:23 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=141862&r2=141861&pathrev=141862
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gpu_util.cc?r1=141862&r2=141861&pathrev=141862
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=141862&r2=141861&pathrev=141862
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.h?r1=141862&r2=141861&pathrev=141862
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=141862&r2=141861&pathrev=141862
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.cc?r1=141862&r2=141861&pathrev=141862

Added a command line flag that disables force-compositing-mode and modified
the about:flags entry to provide a dropdown with three
options : "DEFAULT", "ENABLED", "DISABLED". This will be useful in
conjunction with the FMC field trial as it will allow clients
who are in the FCM trial group to force FCM off.
BUG=114549
Review URL: https://chromiumcodereview.appspot.com/10546113
------------------------------------------------------------------------

chro...@googlecode.com

unread,
Jun 20, 2012, 7:13:21 PM6/20/12
to chromi...@chromium.org
Updates:
Owner: vang...@chromium.org
Blockedon: -chromium:111967 -chromium:114551 -chromium:123103
-chromium:128058 -chromium:129194 chromium:111967 chromium:114551
chromium:123103 chromium:128058 chromium:129194

Comment #24 on issue 114549 by wiltz...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

I meant to assign the launch bug to myself, not this one... Vangelis is
still right PoC here.

chro...@googlecode.com

unread,
Sep 6, 2012, 10:02:51 AM9/6/12
to chromi...@chromium.org
Updates:
Blockedon: chromium:140927

Comment #28 on issue 114549 by tha...@chromium.org: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

chro...@googlecode.com

unread,
May 23, 2013, 4:08:47 AM5/23/13
to chromi...@chromium.org

Comment #34 on issue 114549 by stepien....@gmail.com: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

Isn't this done?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

chro...@googlecode.com

unread,
May 24, 2013, 1:11:55 AM5/24/13
to chromi...@chromium.org

Comment #35 on issue 114549 by vange...@google.com: Enable
--force-compositing-mode on desktop platforms
http://code.google.com/p/chromium/issues/detail?id=114549

Missing linux and mac
Reply all
Reply to author
Forward
0 new messages