Re: Issue 128367 in chromium: ash_shell doesn't process mouse events unless run with --touch-optimized-ui=disabled

1 view
Skip to first unread message

chro...@googlecode.com

unread,
May 16, 2012, 2:44:54 PM5/16/12
to chromi...@chromium.org

Comment #6 on issue 128367 by rby...@chromium.org: ash_shell doesn't
process mouse events unless run with --touch-optimized-ui=disabled
http://code.google.com/p/chromium/issues/detail?id=128367

CL in review here: http://codereview.chromium.org/10386175/

chro...@googlecode.com

unread,
May 17, 2012, 3:27:58 PM5/17/12
to chromi...@chromium.org

Comment #7 on issue 128367 by bugdro...@chromium.org: ash_shell doesn't
process mouse events unless run with --touch-optimized-ui=disabled
http://code.google.com/p/chromium/issues/detail?id=128367#c7

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=137694

------------------------------------------------------------------------
r137694 | rby...@chromium.org | Thu May 17 11:31:00 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/message_pump_x.cc?r1=137694&r2=137693&pathrev=137694

Initialize XInput2 on demand - fixes ash_shell mouse events

MessagePumpX::HasXInput2 currently assumes a message pump has already been
created and so XInput2 has been initialized. This may not always be the
case (eg. when deciding early at startup whether we should load
touch-specific resources).

Instead we now initialize XInput2 on demand - either when the message pump
is created, or when HasInput2 is called earlier.

BUG=128367
TEST=

Review URL: https://chromiumcodereview.appspot.com/10386175
------------------------------------------------------------------------

Reply all
Reply to author
Forward
0 new messages