Re: Issue 122734 in chromium: Sync: Wrench error badge and Wrench menu passphrase errors are lost

[chro...@googlecode.com]

Comment #4 on issue 122734 by dhar...@google.com: Sync: Wrench error badge
and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

any updates? we are branching next week and beta will happen soon.

[chro...@googlecode.com]

Comment #5 on issue 122734 by z...@chromium.org: Sync: Wrench error badge

and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

The first issue is due to not having started syncing with the server.
Basically, since no sync engine events are happening, and nothing currently
listens to NOTIFICATION_SYNC_CONFIGURE_BLOCKED, we're not updating the sync
ui. I don't think this is a big issue.

For the second part, there does indeed seem to be an issue. The customize
dialog didn't go away (presumably because I didn't enter a passphrase), but
it didn't print the red error text either. When I canceled out and reopened
the dialog, passwords was preselected, but there was no error badge. At
that point if I refreshed the UI, it printed the "sign in the chrome ..."
for a second, then after a small delay showed the passphrase error text and
the badge. If I go to about:sync after, passwords is not in the routing
info, so we haven't actually called into Configure.

It appears that we're updating the preferred types before we check for
failed passphrase. Drew, I think you had made some changes to this recently?

[chro...@googlecode.com]

Updates:
Owner: atwil...@chromium.org

Comment #6 on issue 122734 by z...@chromium.org: Sync: Wrench error badge

and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #7 on issue 122734 by atwil...@chromium.org: Sync: Wrench error

badge and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

Nicolas, I'm not sure if I understand your question about updating
preferred types before checking for failed passphrase? We always update
preferred types regardless of passphrase state, since the user may want to
disable the failing datatype. Is there some subtlety we need to be
concerned about?

[chro...@googlecode.com]

Updates:
Labels: Merge-Requested

Comment #9 on issue 122734 by atwil...@chromium.org: Sync: Wrench error

badge and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

[chro...@googlecode.com]

Updates:
Status: Fixed
Owner: anna...@chromium.org
Cc: atwil...@chromium.org

Comment #10 on issue 122734 by atwil...@chromium.org: Sync: Wrench error

badge and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

Reassigning to annapop for verification on canary channel. Please bounce
back to me for merging to M20 when you're done.

[chro...@googlecode.com]

Updates:
Labels: -Merge-Requested Merge-Approved

Comment #12 on issue 122734 by dhar...@chromium.org: Sync: Wrench error

badge and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

[chro...@googlecode.com]

Comment #13 on issue 122734 by atwil...@chromium.org: Sync: Wrench error

badge and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

Be sure to ping me when you finish verifying so I can merge - I think we're
running up on the Beta deadline.

[chro...@googlecode.com]

Updates:
Labels: VerifiedIn-M21

Comment #14 on issue 122734 by anna...@chromium.org: Sync: Wrench error

badge and Wrench menu passphrase errors are lost
http://code.google.com/p/chromium/issues/detail?id=122734

Verified fix, build 21.0.1138.0. One minor caveat is that after the upgrade
on page refresh in Settings when the passphrase is not seen, the passphrase
error actually flashes and then is not visible again. This does not repro
after a clean install and then step 4.