Re: Issue 2393 in chromium: Support user stylesheet

1 view
Skip to first unread message

chro...@googlecode.com

unread,
Feb 24, 2010, 10:35:14 AM2/24/10
to chromi...@chromium.org
Updates:
Status: Started
Owner: tony.chromium

Comment #42 on issue 2393 by tony.chromium: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

UI-less version in the works.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

chro...@googlecode.com

unread,
Mar 14, 2010, 11:49:29 PM3/14/10
to chromi...@chromium.org

Comment #44 on issue 2393 by bugd...@chromium.org: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=41561

------------------------------------------------------------------------
r41561 | to...@chromium.org | 2010-03-14 20:39:50 -0700 (Sun, 14 Mar 2010) |
7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/user_style_sheet_watcher.cc?r1=41561&r2=41560
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/user_style_sheet_watcher.h?r1=41561&r2=41560

Connect UserStyleSheetWatcher to FileWatcher to have changes to
Default/User StyleSheets/Custom.css instantly change layout in
all your tabs.

BUG=2393

Review URL: http://codereview.chromium.org/799005
------------------------------------------------------------------------

chro...@googlecode.com

unread,
Mar 15, 2010, 12:30:07 AM3/15/10
to chromi...@chromium.org
Updates:
Status: Fixed

Comment #45 on issue 2393 by tony.chromium: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

User style sheets should work with --enable-user-stylesheet if you're using
a ToT
build. There's no UI (as mentioned in comment 4). We haven't pushed a
version to the
dev channel with this feature yet.

I also filed issue 38182 for getting rid of the command line flag and issue
38183 for
being able to access this from an extension.

chro...@googlecode.com

unread,
Mar 15, 2010, 12:34:07 AM3/15/10
to chromi...@chromium.org

Comment #46 on issue 2393 by simo.melenius: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

Thanks, this is great! I'll be happy to test this; how long will it take
until it gets
out to the dev channel?

chro...@googlecode.com

unread,
Mar 19, 2010, 11:00:13 AM3/19/10
to chromi...@chromium.org

Comment #47 on issue 2393 by simon.bohlin: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

Yes, any approximation when it'll hit the Dev or even Beta channel?

chro...@googlecode.com

unread,
Mar 20, 2010, 5:17:09 AM3/20/10
to chromi...@chromium.org

Comment #48 on issue 2393 by tony.chromium: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

This is in 5.0.356.X that was just released on the dev channel.
http://googlechromereleases.blogspot.com/

chro...@googlecode.com

unread,
Mar 20, 2010, 12:19:10 PM3/20/10
to chromi...@chromium.org

Comment #49 on issue 2393 by d...@chromium.org: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

This is fantastic Tony!

Just to point out a typo between Comment 43 and 44, the directory name to
use is:
Default/User StyleSheets/Custom.css

ie, "User StyleSheets" with an "s" at the end.

But I notice if you start with --enable-user-stylesheet, it automatically
creates the
directory anyway.

This is working great with my testing in Chrome 5.0.356.2 (Official Build
42060) dev

chro...@googlecode.com

unread,
Mar 27, 2010, 10:00:02 PM3/27/10
to chromi...@chromium.org

Comment #50 on issue 2393 by mattengi: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

Great! thx for this patch. This thing is only reason for using firefox
instead of chrome.

But I dont know how can I enable option "Allow pages to choose their own
fonts,
instead of my selections above" like in firefox?

I don't know about much about css. But I'm used to terminal, vim and sort
of that.
Plz give some hint : )

Thanks for this effort again.

chro...@googlecode.com

unread,
May 5, 2010, 6:40:14 AM5/5/10
to chromi...@chromium.org

Comment #52 on issue 2393 by mkterra: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

This doesn't seem to be working on my end... I created a Custom.css file in
the "User
StyleSheets" (with an 's') folder in the Default profile folder, then
pasted in the
code for this style:
http://userstyles.org/styles/23032

And saved the file. But it does not take effect even after I restart the
browser
(with or without --enable-user-stylesheet). Installing the style as a
userscript
*does* work, so I don't think it's an issue with the style code.

I'm on the latest Beta, 5.0.375.29 (Official Build 46008) beta.

--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

chro...@googlecode.com

unread,
May 10, 2010, 2:16:29 AM5/10/10
to chromi...@chromium.org

Comment #53 on issue 2393 by tony.chromium: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

@mkterra: If you properly pass --enable-user-stylesheet, when you launch
chrome, it will automatically create
"User StyleSheets\Custom.css" in your profile directory.

chro...@googlecode.com

unread,
May 10, 2010, 6:31:55 AM5/10/10
to chromi...@chromium.org

Comment #54 on issue 2393 by mkterra: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

It does generate a blank Custom.css file, but pasting code from
userstyles.org into
it (and saving) doesn't seem to do anything, even after restarting the
browser (still
with --enable-user-stylesheet). I've tried a couple of styles without
seeing any
effect:
http://userstyles.org/styles/23032
http://userstyles.org/styles/23433

By the way, I thought your changes in Issue 38182 removed the need for
--enable-user-
stylesheet? Was that reverted later in a different bug?

chro...@googlecode.com

unread,
May 10, 2010, 7:30:52 AM5/10/10
to chromi...@chromium.org

Comment #55 on issue 2393 by mkterra: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

Oh wait, I've got it: Chrome doesn't support @-moz-document url-prefix.
(Are there
plans to add that?)

chro...@googlecode.com

unread,
May 10, 2010, 8:28:16 PM5/10/10
to chromi...@chromium.org

Comment #56 on issue 2393 by tony.chromium: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

The removal of --enable-user-stylesheet didn't make it into beta, but it is
removed in the dev channel builds.

Please file a bug at bugs.webkit.org about supporting @document url-prefix.

chro...@googlecode.com

unread,
May 17, 2010, 2:03:53 PM5/17/10
to chromi...@chromium.org

Comment #57 on issue 2393 by d...@chromium.org: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

If removal of --enable-user-stylesheet didn't make it into beta, does that
mean this is
not a supported feature for Chrome 5, but will be a supported feature for
Chrome 6?

chro...@googlecode.com

unread,
May 17, 2010, 7:56:53 PM5/17/10
to chromi...@chromium.org

Comment #58 on issue 2393 by tony.chromium: Support user stylesheet
http://code.google.com/p/chromium/issues/detail?id=2393

@dhw: I'm not sure what you mean by "supported". In Chrome 5, you will be
able to enable this feature using the
command line.
Reply all
Reply to author
Forward
0 new messages