Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  11 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
chrom...@googlecode.com  
View profile  
 More options Jun 6 2012, 11:25 am
From: chrom...@googlecode.com
Date: Wed, 06 Jun 2012 15:25:41 +0000
Local: Wed, Jun 6 2012 11:25 am
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #1 on issue 131306 by stefa...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

would introducing a vertical scale solve the problem?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 6 2012, 2:56 pm
From: chrom...@googlecode.com
Date: Wed, 06 Jun 2012 18:56:42 +0000
Local: Wed, Jun 6 2012 2:56 pm
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #2 on issue 131306 by nd...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

That might work! :)

I'd be curious how that fares against always having the Y axis be  
0-1000/30.0ms, such that 16.6ms was exactly in the middle. That is very  
predictable.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 6 2012, 3:02 pm
From: chrom...@googlecode.com
Date: Wed, 06 Jun 2012 19:02:42 +0000
Local: Wed, Jun 6 2012 3:02 pm
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #3 on issue 131306 by pfeld...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

I am with Nat on this one. I.e. 33.3 as a total.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 7 2012, 2:57 pm
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 18:57:04 +0000
Local: Thurs, Jun 7 2012 2:57 pm
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph
Updates:
        Status: Started
        Owner: ca...@chromium.org

Comment #4 on issue 131306 by ca...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Proposed fix upstream (also a couple of screenshots):  
https://bugs.webkit.org/show_bug.cgi?id=88556

I left a fallback to autoscale -- otherwise, in cases where all frames are  
long, all bars go for the entire height of the window and overview just  
stops making sense.
Also added two horizontal lines @ 30 and 60fps.

Another option that I see is providing some ping-like statistics in a  
pop-up over overview, e.g.:

frame duration: min 0.015ms avg 0.18 max 0.120ms etc.

Would it make sense?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 7 2012, 3:19 pm
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 19:19:04 +0000
Local: Thurs, Jun 7 2012 3:19 pm
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #5 on issue 131306 by nd...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

That's a fair point, I do understand the point behind "everything is slow"  
case.

I really like the horizontal lines. Can we make them on-top so they're more  
obvious? They're very faint.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 7 2012, 3:21 pm
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 19:21:04 +0000
Local: Thurs, Jun 7 2012 3:21 pm
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph
Updates:
        Cc: vse...@chromium.org

Comment #6 on issue 131306 by ca...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

(No comment was entered for this change.)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 7 2012, 3:47 pm
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 19:47:04 +0000
Local: Thurs, Jun 7 2012 3:47 pm
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #7 on issue 131306 by ca...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Made lines darker, added two screenshots for lines in foreground and in  
background.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 8 2012, 11:06 am
From: chrom...@googlecode.com
Date: Fri, 08 Jun 2012 15:06:13 +0000
Local: Fri, Jun 8 2012 11:06 am
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #9 on issue 131306 by ca...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

> /me wonders if we should use two colors that aren't being used for color
> categories. E.g. bright red or something. Using purple and green I think
> imply to a casual consumer that those are where you want your purple and
> green lines to be, which at all the case.

Changed it to pale pink -- doesn't look too aggressive (IMHO), but well  
visible over both white and colored bars.

> dumb question guy has a dumb question... erm, the lower of the two lines  
> --- does
> that imply 120fps or 30? It seems to me since the heights of these bars  
> are
> **duration** not rate, the lower one would be 120, but then it makes me  
> think we
> really only need the 60fps line.

We always draw just lines for 30 (higher) and 60 (lower) FPS . But I do  
read you -- added labels ;)

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 8 2012, 11:39 am
From: chrom...@googlecode.com
Date: Fri, 08 Jun 2012 15:39:28 +0000
Local: Fri, Jun 8 2012 11:39 am
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #10 on issue 131306 by pfeld...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

I would draw them using dark color (#333), probably using dotted pattern.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 8 2012, 1:39 pm
From: chrom...@googlecode.com
Date: Fri, 08 Jun 2012 17:39:22 +0000
Local: Fri, Jun 8 2012 1:39 pm
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

Comment #11 on issue 131306 by nd...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Thanks so much guys! The latest screenshot is very <3.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 9 2012, 6:22 am
From: chrom...@googlecode.com
Date: Sat, 09 Jun 2012 10:22:54 +0000
Local: Sat, Jun 9 2012 6:22 am
Subject: Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph
Updates:
        Status: Fixed

Comment #12 on issue 131306 by ca...@chromium.org: Hard to see impact of  
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Cool! Landed it as http://trac.webkit.org/changeset/119896


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »