Issue 243275 in chromium: Print preview is misplaced and covering bookmark folders.

[chro...@googlecode.com]

Status: Untriaged
Owner: ----
CC: ligim...@chromium.org, pav...@chromium.org
Labels: Type-Bug-Regression Pri-1 Cr-UI-Browser-PrintPreview OS-Chrome M-29

New issue 243275 by agau...@chromium.org: Print preview is misplaced and
covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

Google Chrome 29.0.1513.1 (Official Build 201220) dev
Platform 4168.0.0 (Official Build) dev-channel x86-alex_he

What steps will reproduce the problem?
1. Open yahoo.com
2. Print any web page (ctrl+p)
3. Observe print preview screen is not properly placed.


What is the expected output?
Print preview should not be placed above browser (see attached screenshot)
and should cover bookmarks folders.

What do you see instead?
1. Print preview is placed partially above browser bookmark menu. (covering
bookmarks folders)
2. blank space in the bottom of the screen. (looks weird )

Please use labels and text to provide additional information.
This is regression from
M28 (28.0.1500.20 (Official Build 201172)/
4100.17.0 (Official Build) dev-channel x86-alex_he)




Attachments:
M29_print_preview_issue.png 356 KB
M28_correct_behavior.png 239 KB

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Cc: witt...@chromium.org

Comment #2 on issue 243275 by the...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: witt...@chromium.org
Labels: -Cr-Services-CloudPrint

Comment #4 on issue 243275 by rltosc...@google.com: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

This has nothing to do with cloudprint, this is just a print preview issue.

[chro...@googlecode.com]

Updates:
Owner: rfev...@chromium.org
Cc: we...@chromium.org

Comment #5 on issue 243275 by witt...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

The overlap with the browser chrome is WAI with the new web contents modal
dialog style.

Rune, can you look into the other issues identified? I know Wei had to
deal with the dialog positioning in her earlier work.

[chro...@googlecode.com]

Updates:
Cc: sgabr...@chromium.org

Comment #6 on issue 243275 by rfev...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

Both of these are WAI according to the spec I was working towards:
https://docs.google.com/a/google.com/folder/d/0B6x6iYCtKinEUTFOWUJFTWJFSTA/edit?docId=0B6x6iYCtKinERFBFenZxdlVCQUk

I can make the preview larger if that's desired - Sebastien?

[chro...@googlecode.com]

Comment #8 on issue 243275 by rfev...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

The print preview scales based on the browser window size. A larger browser
window creates a bigger preview.

The overlapping the bookmark bar thing seems to be a general issue, I'm
using the same positioning code as the other dialogs.

[chro...@googlecode.com]

Comment #9 on issue 243275 by sgabr...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

OK.

About the size of the print dialog, are talking about wider or taller ?
Right now on my canary build on mac the dialog stays the same size
independently from the window size.

[chro...@googlecode.com]

Comment #10 on issue 243275 by rfev...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

Both wider and taller, its size is basically the size of the browser window
minus constants in both dimensions. It resizes for me both on Linux and
Views/ChromeOS. I'm not sure why it doesn't on Mac.

[chro...@googlecode.com]

Comment #12 on issue 243275 by sgabr...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

I see I tried in on Chrome OS. Yes it would be nice to increase the height
to the padding is the same left/right/bottom.

[chro...@googlecode.com]

Comment #13 on issue 243275 by vitalyb...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

Also please make sure that both top and bottom bars are taken into account.

Attachments:
preview.png 91.8 KB

[chro...@googlecode.com]

Comment #14 on issue 243275 by bugdro...@chromium.org: Print preview is

misplaced and covering bookmark folders.

http://code.google.com/p/chromium/issues/detail?id=243275#c14

------------------------------------------------------------------------
r202330 | rfe...@chromium.org | 2013-05-26T02:15:46.769904Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_dialog_controller.cc?r1=202330&r2=202329&pathrev=202330

Adjust PrintPreview height.

Have the bottom margin of the print preview dialog be the same as
the side margins (25 pixels).

BUG=243275

Review URL: https://chromiumcodereview.appspot.com/15885004
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #15 on issue 243275 by bugdro...@chromium.org: Print preview is

misplaced and covering bookmark folders.

http://code.google.com/p/chromium/issues/detail?id=243275#c15

------------------------------------------------------------------------
r202681 | wit...@chromium.org | 2013-05-28T23:12:59.074993Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view_layout.cc?r1=202681&r2=202680&pathrev=202681
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view_layout.h?r1=202681&r2=202680&pathrev=202681

Redo display of web contents modal dialog under the bookmark bar

This change was made in http://crrev.com/200122, but appears to have
been lost in a merge at http://crrev.com/200407.

BUG=243275

Review URL: https://chromiumcodereview.appspot.com/16021009

[chro...@googlecode.com]

Comment #16 on issue 243275 by benh...@chromium.org: Print preview is

misplaced and covering bookmark folders.
http://code.google.com/p/chromium/issues/detail?id=243275

Can we close this as fixed?