Re: Issue 74065 in chromium: Lion: Need to use new full-screen API
chro...@googlecode.com
Comment #5 on issue 74065 by dan2...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
it's not playing as it should with mission control and it's a hassle to get
out of fullscreen mode. This isn't the fullscreen kind of experience Lion
intends on.
chro...@googlecode.com
Comment #6 on issue 74065 by mikeal.rogers: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
playing with this today on Lion. the current full screen support is
actually more confusing than not having it at all.
Mac OS X *normal* full screen experience pops the app out of it's current
space. Chrome doesn't not yet it's the same top-right button.
Chrome's three finger swipe tab expose is now broken and conflicts with
existing gestures in Lion. This is related to full screen because that was
previously the only way to explore tabs in full screen.
overall it's a pretty terrible experience.
chro...@googlecode.com
Comment #7 on issue 74065 by elite...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
adding my vite that Chrome needs to support this, if it wants to play nice
with the Lion experience; the current full screen won't do.
chro...@googlecode.com
Comment #8 on issue 74065 by alexande...@googlemail.com: Lion: Need to use
http://code.google.com/p/chromium/issues/detail?id=74065
Also, in Lion you get access to the Dock (when it is on auto-hide) from
fullscreen apps. In Chrome you do not. Chrome really should use the new
APIs that come with lion.
chro...@googlecode.com
Comment #9 on issue 74065 by jro...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Yep, I also think this is the single most important feature to support on
Lion right now.
- People will feel helpless if they accidentally clicked the full-screen
icon and don't know how to get back.
- The new fullscreen mode rocks and I use it all the time. Most Apple apps
already support this and third-party apps are sure to follow. Chrome should
really make this a priority.
chro...@googlecode.com
Comment #10 on issue 74065 by kei...@google.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Is anyone working on this? I have looked at the code. It will need a big
rewrite but I think I can do it.
chro...@googlecode.com
Comment #17 on issue 74065 by x...@xuzz.net: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
I agree that adding an option for a feature like this does not make sense.
However, I do believe that both modes of full-screen — the Safari-like one
for Lion, and the presentation-style one currently included — should be
included in Chrome.
I think the best way to think of this is not to think of
Lion's "full-screen apps" feature as even covering the same area as
Chrome's current "full screen". From what I can tell, the goal of Lion's
feature is similar to the point of the "maximize" button on other
platforms: it's not the UI for an alternate use-case for the application,
just a more streamlined way to view the same data. And, just like as
Chrome's Windows maximized layout is slightly different (tabs further up
inside the title bar), it makes sense for the Lion "full-screen app" design
to be slightly different from Chrome in a window. In particular, I'd
suggest hiding the bookmarks bar (even if set to always enabled) unless the
mouse is hovering on the toolbar, tabbar, or menubar (just like in Safari,
and only if the bookmarks bar is set to always be enabled).
However, this most certainly does not remove the need or usefulness of the
current "presentation" mode. I don't have a Windows machine, but I'd
suspect that Chrome has that same feature there, along with the support for
a maximized window. To do this, you'd just keep the current "Enter Full
Screen" and "Exit Full Screen" menu items (possibly changing it to
something like "Presentation Mode"), and then add support for Safari and
Lion style full screen when you press the little icon in the top right.
Anyway, I'm not a Mac (or Chromium) developer, so unfortunately I can't
just go make you a patch for that. But, if Chrome decides that "real" Lion
fullscreen isn't in the plan, I'll take a look and see what I can figure
out to try and get the above implemented.
chro...@googlecode.com
Comment #18 on issue 74065 by wmdo...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Please implement both options, in any case Lion fullscreen support. Chrome
needs OS-specific enhancements to make people switch from Safari.
chro...@googlecode.com
Comment #19 on issue 74065 by alexande...@googlemail.com: Lion: Need to use
http://code.google.com/p/chromium/issues/detail?id=74065
i think x...@xuzz.net idea is on the right track.
I would suggest to leave the fullscreen mode in the menu where it is right
now, because OSX-Style Fullscreen will get triggered trough the buttons on
the right, neither safari nor mail have a menu-switch for that. So both
solutions could easily live together, the old fullscreen (under the old
name perhaps?), and the lion fullscreen only triggerable through the
buttons on the right. Each with its own implementation, so that for other
system nothing changes(cause the button is only on OSX) and OSX users get
the common and expected experience out of the "Fullscreen-Button".
chro...@googlecode.com
Comment #20 on issue 74065 by jro...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Please take a look at lions preview.app.
It has the lion fullscreen mode + the fullscreen diashow/presentation mode.
Bothe behave differently, not too well together, are easily confused, yet
both implemented. Seriously, check it out, then come back to discuss.
I personally vote fot a safari-like lion fullscreen with the option for
chromelike fullscreen
chro...@googlecode.com
Comment #21 on issue 74065 by kei...@google.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
I think the naming "full screen" is Apple's mistake. It's just windows
maximizing.
We have window maximizing on Windows so we should support the same feature
for Mac too.
Here is my build with basic support for Lion full screen.
https://docs.google.com/leaf?id=0B4aiM9jljUy8Y2NkZDUyNWItYmFiNS00ZjFhLWE4NGItMTM3OTAyZTY4OGE1&hl=ja
I think we could start from this and iterate on it to get the animations
right.
chro...@googlecode.com
Comment #22 on issue 74065 by jro...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
@ kei... : Very nice.
That's exactly how it should be. Lion fullscreen with the button,
CMD+SHIFT+F for classic fullscreen, combination working well.
chro...@googlecode.com
Comment #23 on issue 74065 by wmdo...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
It's not a mistake; the menu bar and dock both disappear. Window maximizing
in Windows doesn't hide the taskbar.
chro...@googlecode.com
Comment #27 on issue 74065 by elite...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
100% agreed with x...@xuzz.net, this is how it should be, IMHO.
chro...@googlecode.com
Comment #28 on issue 74065 by wmdo...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
I think the team should implement it like kei did. And quickly, because
Lion is coming out within a week and the current fullscreen-button
behaviour will confuse a lot of people.
chro...@googlecode.com
Comment #30 on issue 74065 by wout.mer...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Can't both full-screen modes be addressed using an extra on-tabbar UI
element?
There are good reasons for both showing and hiding tabs+address bar in full
screen mode, so how about adding a button in the top right of the tab bar
that allows the user to show/hide the tab bar? For example a pushpin. With
the button active, the tab and address bar both show, and with the button
off, it auto-hides as in the current full-screen implementation.
The default could be auto-hide as it is now. The menu bar would always
auto-hide, as is normal with full-screen apps. This would address Graeme's
concern as well.
What does need to be done in any case (urgently I might add since the
release is near) is to make Chrome use the OS X full-screen UI, so that it
gets its own space and other benefits of integration with Mission Control.
As mentioned before, the current implementation is very confusing under OS
X. The way kei does it is great.
chro...@googlecode.com
Comment #31 on issue 74065 by kei...@google.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
I cleaned up my code and uploaded it. http://codereview.chromium.org/7355016
chro...@googlecode.com
Comment #32 on issue 74065 by radut...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
I'd just like to say that kei's implementation of Lion's full-screen mode
is so good that i'm now using it as my primary browser, and I'm
recommending it to friends switching to Lion.
The current implementation of the full-screen button is very wrong. The
button is advertising a feature that behaves very differently from the
system standard, and it could hurt the perceived quality of the app. I
think it might actually be better to remove it while it doesn't work as
expected, to avoid confusion and frustration.
chro...@googlecode.com
Comment #33 on issue 74065 by wyc...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
I agree with radut. The full-screen widget is a system Lion widget with
expected behavior. This includes participation in the swipe gesture that
changes spaces and Mission Control. Nothing stops Chrome from having its
own presentation-style full screen mode, but the behavior of the system
widget should match the expected behavior.
chro...@googlecode.com
Comment #34 on issue 74065 by jro...@gmail.com: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Yes. Just merge the **** patch! It's the right thing to do.
chro...@googlecode.com
Comment #42 on issue 74065 by bugdro...@chromium.org: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065#c42
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=92893
------------------------------------------------------------------------
r92893 | rse...@chromium.org | Mon Jul 18 14:28:30 PDT 2011
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/782/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=92893&r2=92892&pathrev=92893
M
http://src.chromium.org/viewvc/chrome/branches/782/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=92893&r2=92892&pathrev=92893
Merge 92728 - [Mac] Remove the Lion fullscreen button until proper
fullscreen support is added.
BUG=74056,74065
TEST=Run on Lion. No fullscreen button in upper right.
Review URL: http://codereview.chromium.org/7390012
TBR=rse...@chromium.org
Review URL: http://codereview.chromium.org/7399033
------------------------------------------------------------------------
chro...@googlecode.com
Comment #43 on issue 74065 by rse...@chromium.org: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
The next Chrome 13 update will have the fullscreen button removed.
chro...@googlecode.com
Cc: ser...@chromium.org vandanas...@chromium.org
Comment #45 on issue 74065 by CalebEgg: Lion: Need to use new full-screen
API
http://code.google.com/p/chromium/issues/detail?id=74065
Issue 90100 has been merged into this issue.
chro...@googlecode.com
Comment #47 on issue 74065 by mme...@chromium.org: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Issue 90950 has been merged into this issue.
chro...@googlecode.com
Comment #50 on issue 74065 by meh...@chromium.org: Lion: Need to use new
full-screen API
http://code.google.com/p/chromium/issues/detail?id=74065
Issue 91117 has been merged into this issue.