Issue 131566 in chromium: Drudge doesn't display properly

[chro...@googlecode.com]

Status: Unconfirmed
Owner: ----
Labels: OS-Android Pri-2

New issue 131566 by jtlov...@gmail.com: Drudge doesn't display properly
http://code.google.com/p/chromium/issues/detail?id=131566

Chrome Version:
Application Version (from "Chrome Settings > About Chrome"):
URLs (if applicable):

From "Android Settings > About Phone/Tablet"
Build number:
Device:

Behavior in Android Browser (if applicable




Steps to reproduce:
1 go to drudgereport and take a look at the rendering. Left column way to
big relative to rest of page.
3.

Expected result:


Actual result:

[chro...@googlecode.com]

Comment #3 on issue 131566 by mkarhi...@gmail.com: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

Same problem for me. Page fixes itself if I rotate the phone to landscape
and back to portrait. Upon refresh, the left column has extra-large text
again.

Screenshot attached.

Details:

Samsung Galaxy S2 Skyrocket running Android 4.0.4

Chrome version 18.0.1025469

Attachments:
Screenshot_2013-01-27-20-59-49.png 259 KB

[chro...@googlecode.com]

Comment #4 on issue 131566 by cenglan...@gmail.com: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

Same problem. Droid 4...

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #5 on issue 131566 by deslock...@gmail.com: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

Same problem on my NeXus 5.

chrome 31.0.1650.59.

amazed this problem has not been corrected after all this time.

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: ted...@chromium.org

Comment #6 on issue 131566 by krav...@chromium.org: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

Able to repro on Nexus 5.

[chro...@googlecode.com]

Updates:
Owner: joh...@chromium.org
Cc: ted...@chromium.org
Labels: Cr-Blink-TextAutosize

Comment #7 on issue 131566 by ted...@chromium.org: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #8 on issue 131566 by deslock...@gmail.com: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

under advance settings , if you go to accessibility and check use force
zoom then it suphould fix your problem! let me know if this helps. it is
obvious Google isn't going to fix this anytime soon

[chro...@googlecode.com]

Comment #9 on issue 131566 by mkarhi...@gmail.com: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

Force zoom in advanced settings did not fix the problem for me.

Samsung Galaxy S2 Skyrocket w/CyanogenMod 10.2.0-skyrocket, Android 4.3.1

[chro...@googlecode.com]

Updates:
Owner: timvolod...@chromium.org
Cc: joh...@chromium.org p...@chromium.org sko...@chromium.org

Comment #10 on issue 131566 by joh...@chromium.org: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

Hmm, this is a tricky one. The page is essentially a giant 3 column table
(plus 2 separator columns):

<table CELLPADDING="3" WIDTH="100%">
<tr>
<td ALIGN="LEFT" VALIGN="TOP" WIDTH="30%">...</td>
<td align="center" valign="top" width="3">...</td>
<td ALIGN="LEFT" VALIGN="TOP" WIDTH="30%">...</td>
<td align="center" valign="top" width="3">...</td>
<td ALIGN="LEFT" VALIGN="TOP" WIDTH="40%">...</td>
</tr>
</table>

If you look at the page while it loads, you'll see that due to incremental
layout, the left column initially spans the full width of the page, and get
autosized accordingly. Then a little while later the next two columns load
and the left columns gets resized to only 1/3 of the page width, but we
can't decrease the font size accordingly, since it was locked by
https://bugs.webkit.org/show_bug.cgi?id=108205 during the first layout.

Maybe once the page finishes loading (i.e. DOMContentLoaded) we should
consider unlocking the multipliers and allowing sizes to change once at
that point? :|

[chro...@googlecode.com]

Comment #11 on issue 131566 by jtlov...@gmail.com: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

I think I wrote this bug report nearly 2 years ago? The stock android
browser seems to render it? Since Drudge is nearly the most visited site on
the entire internet I'd think this would be solved? I find if I rotate the
phone a few times it corrects.

[chro...@googlecode.com]

Comment #13 on issue 131566 by joh...@chromium.org: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

You mean revert wkbug.com/108205 and simply don't lock multipliers? Yeah,
that might be best, but we'd need to be very careful to avoid bugs like
issue 167977, issue 168159 and issue 169795. They have subtle (but not
insurmountable) root causes; for example issue 168159 was caused by layout
cycles where:

1. a block got autosized
2. because it had been autosized its width changed
3. hence clusters were determined differently*
4. the new cluster contained less elements and hence failed to meet the
minimum amount of text criterion
5. the block stopped being autosized
6. hence the clusters were determined the same way they had been previously
7. repeat from step 1 :)

wkbug.com/108205 fixed this by preventing multipliers from changing; if we
reverted that we'd instead need to fix the root cause, and make sure the
layout was fully stable.

In one of the other cases, text sizes were changing during page load,
because the text was in a table with unspecified width, so initially the
table was quite narrow, but autosizing made the text inside wider, hence
the table grew, hence the text grew, hene the table grew, hence the text
grew, etc until the table reached the full width of its containing block
(each iteration happening according to the incremental layouts taking place
during page load). IIRC Mozilla solve this by being smart about the way
text caused shrink-wrapping blocks to expand: in cases where font size is
proportional to block width, and block width is proportional to font size,
they immediately fully expand the block to the width of its containing
block. We would have to do something similar...

*: the reason clusters are determined differently is probably due to one of
wkbug.com/108411, wkbug.com/109054, wkbug.com/109573 and wkbug.com/109825
whose job was to fix reddit (issue 175178).

[chro...@googlecode.com]

Comment #15 on issue 131566 by bugdro...@chromium.org: Drudge doesn't
display properly
http://code.google.com/p/chromium/issues/detail?id=131566#c15

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=169572

------------------------------------------------------------------
r169572 | timvo...@chromium.org | 2014-03-19T18:50:21.362078Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/TextAutosizer.cpp?r1=169572&r2=169571&pathrev=169572
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/TextAutosizer.h?r1=169572&r2=169571&pathrev=169572
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=169572&r2=169571&pathrev=169572
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=169572&r2=169571&pathrev=169572
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/text-autosizing/unlock-multipliers-on-DOMContentLoaded-expected.html?r1=169572&r2=169571&pathrev=169572
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/text-autosizing/unlock-multipliers-on-DOMContentLoaded.html?r1=169572&r2=169571&pathrev=169572

TextAutosizer: unlock multipliers on DOMContentLoaded.

This patch unlocks the text autosizing multipliers when
the document has finished parsing. This is necessary
to avoid weird effects when layout changes significantly
during page load. Resetting multipliers allows for a fresh
autosizing pass to take into account the whole document.

In particular this patch fixes issues with overlines on
http://forum.xda-developers.com and partially addresses
inconsistent font size on www.drudgereport.com
(see referenced bugs for details).

BUG=346786,131566

Review URL: https://codereview.chromium.org/189113014
-----------------------------------------------------------------

[chro...@googlecode.com]

Comment #16 on issue 131566 by ivorjos...@gmail.com: Drudge doesn't display
properly
http://code.google.com/p/chromium/issues/detail?id=131566

This issue was fixed with the lasted android chrome update. Finally! Many
thanks :)