Re: Issue 220993 in chromium: Add UMA stats to track the keyboard backlight

[chro...@googlecode.com]

Comment #7 on issue 220993 by arsc...@chromium.org: Add UMA stats to track
the keyboard backlight
http://code.google.com/p/chromium/issues/detail?id=220993

the backlight level is useful, not as much bothered about the other one.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Status: Started

Comment #9 on issue 220993 by de...@chromium.org: Add UMA stats to track

the keyboard backlight
http://code.google.com/p/chromium/issues/detail?id=220993

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #10 on issue 220993 by bugdro...@chromium.org: Add UMA stats to
track the keyboard backlight
http://code.google.com/p/chromium/issues/detail?id=220993#c10

Project: chromiumos/platform/power_manager
Branch : master
Author : Daniel Erat <de...@chromium.org>
Commit : 352d99aa32fdf3951adc2ed514de4f182c956cc8

Code Review +2: Chris Masone
Verified +1: Daniel Erat
Change-Id : Iad45310fce9e3a8e69a2727a1f6dff9d3e315aa3
Reviewed-at : https://gerrit.chromium.org/gerrit/56337

power: Add Power.KeyboardBacklightLevel metric.

This adds a Power.KeyboardBacklightLevel metric that reports
the keyboard backlight brightness every thirty seconds.

It also removes the existing Power.BrightnessAdjust*
metrics. These were enum histograms tracking the number of
times that the panel brightness had been manually adjusted
by the user, but they didn't make much sense: User actions
are the right approach for tracking this, and in fact,
Chrome already reports user action metrics for the panel and
keyboard brightness accelerators. powerd was also recording
the number of SetScreenBrightness D-Bus calls, but these are
received continuously when the user drags the brightness
slider -- a single drag could generate hundreds of these,
each of which would be reported as a separate histogram
sample.

BUG=chromium:220993
TEST=added unit test; also did manual testing via
chrome://histograms

Commit-Queue: Daniel Erat <de...@chromium.org>

M powerd/daemon.cc
M powerd/metrics_constants.cc
M powerd/metrics_constants.h
M powerd/metrics_reporter.cc
M powerd/metrics_reporter.h
M powerd/metrics_reporter_unittest.cc

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #11 on issue 220993 by de...@chromium.org: Add UMA stats to track
the keyboard backlight

http://code.google.com/p/chromium/issues/detail?id=220993

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #12 on issue 220993 by bugdro...@chromium.org: Add UMA stats to
track the keyboard backlight
http://code.google.com/p/chromium/issues/detail?id=220993#c12

------------------------------------------------------------------------
r202294 | de...@chromium.org | 2013-05-25T14:49:37.405616Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=202294&r2=202293&pathrev=202294

chromeos: Add descriptions for power manager metrics.

This adds descriptions for a few histograms that I'm adding
to the power manager:

Power.BatteryDischargeRateWhileSuspended
Power.KeyboardBacklightLevel

It also removes Power.BrightnessAdjustOnAC and
Power.BrightnessAdjustOnBattery. These are being removed from
the power manager; they should be reported as user actions
rather than histograms, and Chrome already reports them as
such.

BUG=218397,220993

Review URL: https://chromiumcodereview.appspot.com/15734015
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Verified

Comment #13 on issue 220993 by chiraggu...@chromium.org: Add UMA stats to

track the keyboard backlight
http://code.google.com/p/chromium/issues/detail?id=220993

Verified on build: 4238.0.0