Issue 126465 in chromium: Off by one error in uniformity trials logic

[chro...@googlecode.com]

Status: Started
Owner: ste...@chromium.org
Labels: Type-Bug Pri-2 Area-Internals

New issue 126465 by ste...@chromium.org: Off by one error in uniformity
trials logic
http://code.google.com/p/chromium/issues/detail?id=126465

There is an off by one error in the uniformity trials logic where the
default group is not reported to the server.

AKA: b/6449821

[chro...@googlecode.com]

Comment #1 on issue 126465 by bugdro...@chromium.org: Off by one error in
uniformity trials logic
http://code.google.com/p/chromium/issues/detail?id=126465#c1

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=135655

------------------------------------------------------------------------
r135655 | ste...@chromium.org | Mon May 07 09:35:24 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=135655&r2=135654&pathrev=135655

Uselessly use the uniformity field trial.

This resolves an off by one error where the default group is never selected
and reported.

BUG=126465
TEST=Ensure that the server is receiving Variation IDs for the default
groups in the uniformity trials (such as 3300000 and 3300100).


Review URL: http://codereview.chromium.org/10377033
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #2 on issue 126465 by ste...@chromium.org: Off by one error in

uniformity trials logic
http://code.google.com/p/chromium/issues/detail?id=126465

Fixed.

[chro...@googlecode.com]

Updates:
Status: Assigned
Labels: Merge-Requested Mstone-20

Comment #3 on issue 126465 by ste...@chromium.org: Off by one error in

uniformity trials logic
http://code.google.com/p/chromium/issues/detail?id=126465

Requesting a merge to M20 before it hits beta. We do a tiny fix to ensure
that a FieldTrial is reporting correctly for all groups.

If we don't merge this, we'll keep getting weird numbers in our analysis
until the fix hits all channels :(

[chro...@googlecode.com]

Updates:
Labels: -Merge-Requested Merge-Approved

Comment #4 on issue 126465 by dhar...@chromium.org: Off by one error in

uniformity trials logic
http://code.google.com/p/chromium/issues/detail?id=126465

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Labels: merge-merged-1132

Comment #5 on issue 126465 by bugdro...@chromium.org: Off by one error in
uniformity trials logic
http://code.google.com/p/chromium/issues/detail?id=126465#c5

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=137469

------------------------------------------------------------------------
r137469 | ste...@chromium.org | Wed May 16 11:51:16 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/chrome_browser_main.cc?r1=137469&r2=137468&pathrev=137469

Merge 135655 - Uselessly use the uniformity field trial.

This resolves an off by one error where the default group is never selected
and reported.

BUG=126465
TEST=Ensure that the server is receiving Variation IDs for the default
groups in the uniformity trials (such as 3300000 and 3300100).


Review URL: http://codereview.chromium.org/10377033

TBR=ste...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391168
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #6 on issue 126465 by ste...@chromium.org: Off by one error in

uniformity trials logic
http://code.google.com/p/chromium/issues/detail?id=126465

This should be fixed.